-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lookup: drop mime and jest from CITGM #1063
Conversation
Should we ping the maintainers first? |
👋 The linked gist with logs in #1060 (comment) has no data - did it timeout? If yes, can we increase the timeout? If we cannot increase the timeout I'd like for us to skip some tests rather than removing Jest entirely (e.g. watch and transform tests take almost a minute, even on my m2 max) |
I'm unable to view the |
It was not a timeout and yeah, I think you won't be able to see the Jenkins UI since we are in lockdown due to the security release. I can re-run it after the security release, but both modules were failing due to "MODULE_NOT_FOUND". Jest: https://gist.github.com/RafaelGSS/57c21139d9f27e855217d5f1e59ff511. |
FWIW, that gist appears to be specific to So... I guess ping me when the lockdown is lifted? (Sorry, I'm not familiar enough with the CITGM project to know how lockdowns work or how long they last.) |
@broofa Here's how |
Okay, I've pushed Hit me up if the problem doesn't go away. |
Thanks! CI for |
@RafaelGSS |
The Jest one is a red herring - it's just a logged error not an actual failure. https://github.com/jestjs/jest/blob/9c9ce8ad80c6719c3378dd0058c173830621a3ff/e2e/__tests__/nativeEsm.test.ts#L31 I can probably avoid logging it, tho. EDIT: jestjs/jest#15166 |
Thank you folks! |
As discussed in the last Release WG meeting, we'll remove the offending modules and according to #1060, those modules are failing often unrelated to machine errors.
cc: @nodejs/releasers